PROPOSAL: Change logic on chain-evolution endpoint#909
Closed
DylasX wants to merge 2 commits intoPokeAPI:stagingfrom
Closed
PROPOSAL: Change logic on chain-evolution endpoint#909DylasX wants to merge 2 commits intoPokeAPI:stagingfrom
DylasX wants to merge 2 commits intoPokeAPI:stagingfrom
Conversation
DylasX
changed the title
Member
|
Closing as this is old and I want to tidy things up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
Working with the endpoint evolution-chain, it's using the evolution_chain_id to filter and get the chain evolution so if you only have the pokemon_id and try to get the evolutions with that endpoint will generate a not expected response so that's why I did this proposal of change the chain id to pokemon id.
Thanks a lot!